Skip to content

Conversation

@q2w
Copy link
Collaborator

@q2w q2w commented Oct 8, 2024

This PR makes below changes,

  1. Renames project to project_id input variable to standardize across terraform blueprints
  2. Adds output variable visibility in UI metadata
  3. Update connection metadata version to match SemVer format.

@q2w q2w requested a review from bharathkkb October 8, 2024 14:19
@q2w q2w marked this pull request as ready for review October 8, 2024 15:02
@q2w q2w requested review from a team and imrannayer as code owners October 8, 2024 15:02
@q2w q2w requested a review from apeabody October 10, 2024 07:33
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @q2w @ayushmjain!

LGTM

@apeabody
Copy link
Contributor

Thanks for including the upgrade guide!

@apeabody apeabody merged commit 04cef76 into terraform-google-modules:master Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants